[webkit-reviews] review requested: [Bug 45059] Add red-black tree capable of holding plain old data (POD) : [Attachment 66391] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 11:57:56 PDT 2010


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 45059: Add red-black tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45059

Attachment 66391: Revised patch
https://bugs.webkit.org/attachment.cgi?id=66391&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Per review comments above and discussion on webkit-dev:

 - Made PODArena self-contained again rather than relying on Arena.h.
 - Adding PODArena and PODRedBlackTree into platform/graphics/gpu for the time
being. If the red/black tree and forthcoming interval tree are generalized to
hold fully arbitrary data types, we can consider moving them.
 - Changed red-black tree's numElements to size and insert to add.


More information about the webkit-reviews mailing list