[webkit-reviews] review denied: [Bug 44695] Add index insertion support to IndexedDB. : [Attachment 66046] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 44695: Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

Attachment 66046: Patch
https://bugs.webkit.org/attachment.cgi?id=66046&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Steve did a review with me on my computer.  His 2 comments:

> doDelete(sqliteDatabase(), "DELETE FROM IndexData WHERE indexId IN (SELECT id
FROM Indexes WHERE objectStoreId = ?)", objectStore->id());

Index on the indexID.



? static void putObjectStoreData(SQLiteDatabase& db, bool isExistingValue,
IDBKey* key, SerializedScriptValue* value, int64_t objectStoreId, int64_t*
dataRowId)

get rid of isExistingValue..just key off of dataRowId