[webkit-reviews] review granted: [Bug 30625] Implement WebGL on Windows : [Attachment 66380] Added ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 2 10:06:12 PDT 2010
Chris Marrin <cmarrin at apple.com> has granted Paul Sawaya <psawaya at apple.com>'s
request for review:
Bug 30625: Implement WebGL on Windows
https://bugs.webkit.org/show_bug.cgi?id=30625
Attachment 66380: Added ChangeLog
https://bugs.webkit.org/attachment.cgi?id=66380&action=review
------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66380&action=prettypatch
> WebCore/ChangeLog:5
> + Refactored out Mac specific code for
platform/graphics/mac/GraphicsContext3D.mm file, leaving general OpenGL code in
platform/graphics/GraphicsContext3D.cpp.
Try to avoid wrapping here (and don't use tabs when you wrap it yourself). And
the OpenGL code is in GraphicsContext3DOpenGL, right?
r+ with those things fixed.
More information about the webkit-reviews
mailing list