[webkit-reviews] review granted: [Bug 43629] Use correct minus glyphs in MathML operators : [Attachment 66352] Revised patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted François Sausset
<sausset at gmail.com>'s request for review:
Bug 43629: Use correct minus glyphs in MathML operators
https://bugs.webkit.org/show_bug.cgi?id=43629

Attachment 66352: Revised patch
https://bugs.webkit.org/attachment.cgi?id=66352&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +inline UChar convertHyphenMinusToMinusSign(UChar glyph)
> +{
> +    // When rendered as a mathematical operator, minus glyph should be
larger.
> +    if (glyph == hyphenMinus)
> +	   return minusSign;
>      
> +    return glyph;
>  }

I don't think this needs to be in the RenderMathMLOperator.h file. It could
just as well be private in the .cpp file.

Thanks for making this more of a "why" comment. It still is slightly oblique,
but I can't figure out an easy way to make it more direct.

Otherwise, patch seems fine.

I’ll set both the review flag and the commit-queue flag, but if you would like
to make the function private, you could clear the commit-queue one.