[webkit-reviews] review granted: [Bug 45091] [DRT/Chromium] Remove dependency to base/task.h and base/timer.h : [Attachment 66337] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 07:34:39 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 45091: [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
https://bugs.webkit.org/show_bug.cgi?id=45091

Attachment 66337: Patch
https://bugs.webkit.org/attachment.cgi?id=66337&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66337&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/Task.h:40
> +class WebTask {
Minor quibble: the Web prefix is typically used in WebKit layer. How about we
call it something like DRTTask. Blergh, that's bad too! Ok, I am out of ideas
-- you can land as-is :)


More information about the webkit-reviews mailing list