[webkit-reviews] review requested: [Bug 44672] Fix warning in wtf/ByteArray.h : [Attachment 66364] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 2 06:28:46 PDT 2010
Csaba Osztrogonac <ossy at webkit.org> has asked for review:
Bug 44672: Fix warning in wtf/ByteArray.h
https://bugs.webkit.org/show_bug.cgi?id=44672
Attachment 66364: proposed fix
https://bugs.webkit.org/attachment.cgi?id=66364&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
First, I tried to use defined but not implemented
copy constructor and operator=. And then I tried
to implement them with ASSERT_NOT_REACHED(), but
MSVC still warns.
I propose to use maximal array size for MSVC
and unsized array for other compilers. It won't
cause memory problems, because you can create
a ByteArray only with its create method, which
absolutely ignores the sized of m_data array.
More information about the webkit-reviews
mailing list