[webkit-reviews] review requested: [Bug 43629] Use correct minus glyphs in MathML operators : [Attachment 66352] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 04:28:13 PDT 2010


François Sausset <sausset at gmail.com> has asked	for review:
Bug 43629: Use correct minus glyphs in MathML operators
https://bugs.webkit.org/show_bug.cgi?id=43629

Attachment 66352: Revised patch
https://bugs.webkit.org/attachment.cgi?id=66352&action=review

------- Additional Comments from François Sausset <sausset at gmail.com>
Proposed changes have been integrated.

About comments, they were here for the first version of the patch. They were
indeed useless in the last version of the patch.
I added a "why" comment in the convertHyphenMinusToMinusSign function.

I was not aware of the replace() method. Thanks for pointing it to me.
Code is much cleaner now.


More information about the webkit-reviews mailing list