[webkit-reviews] review granted: [Bug 45007] Remove rendering types from SubframeLoader and split RenderEmbeddedObject::updateWidget in preparation for moving to DOM : [Attachment 66170] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 1 14:40:43 PDT 2010
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 45007: Remove rendering types from SubframeLoader and split
RenderEmbeddedObject::updateWidget in preparation for moving to DOM
https://bugs.webkit.org/show_bug.cgi?id=45007
Attachment 66170: Patch
https://bugs.webkit.org/attachment.cgi?id=66170&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66170&action=prettypatch
> WebCore/rendering/RenderEmbeddedObject.cpp:369
> + updateWidgetForMediaElement(mediaElement,
onlyCreateNonNetscapePlugins);
I clearly started reviewing this in the wrong order :)
More information about the webkit-reviews
mailing list