[webkit-reviews] review denied: [Bug 44992] [chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface. : [Attachment 66140] Patch

[bugzilla-daemon at webkit.org]

Daniel Cheng <dcheng at chromium.org> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 44992: [chromium] Prepare Clipboard/DragData for transition to new
drag-and-drop interface.
https://bugs.webkit.org/show_bug.cgi?id=44992

Attachment 66140: Patch
https://bugs.webkit.org/attachment.cgi?id=66140&action=review

------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
(In reply to comment #10)
> (In reply to comment #9)
> > Attachment 66140 [details] [details] did not build on chromium:
> > Build output: http://queues.webkit.org/results/3936003
> 
> Can you reupload with a style fix?  Now that issue 44917 is fixed, this
should compile on cr-linux too.

The style error seems to be a false positive (it's warning on the keyword
'NULL' in a comment).

I also made a small fix in DragDataRef, but I'm currently trying to figure out
the regression on my local box--after I split up the drag and drop patches,
it's not working anymore using the "new" way. I want to verify it's not a
problem in the WebKit code before I put the patch up for review again.