[webkit-reviews] review requested: [Bug 42089] reported size of image is changed when page is zoomed in (or out) : [Attachment 66257] patch v3.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 1 13:38:37 PDT 2010


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 42089: reported size of image is changed when page is zoomed in (or out)
https://bugs.webkit.org/show_bug.cgi?id=42089

Attachment 66257: patch v3.2
https://bugs.webkit.org/attachment.cgi?id=66257&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This changes the name "result" to "value", which is what nearby functions use.

Template arguments will cause one extra instantiation of the function.	OTOH,
they might result in better code (since the compiler will have the literal
values to compare), and I think the callers read slightly more clearly than
with function arguments.  (Stroustrup also tends to use template args for
function bounds.)  So in the end I have a very weak preference for template
args.  If you feel strongly, I'll change them.


More information about the webkit-reviews mailing list