[webkit-reviews] review denied: [Bug 45036] [v8] bypass caches when query memory usage from post GC and in crash handler. : [Attachment 66212] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 1 11:35:03 PDT 2010
Adam Barth <abarth at webkit.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 45036: [v8] bypass caches when query memory usage from post GC and in crash
handler.
https://bugs.webkit.org/show_bug.cgi?id=45036
Attachment 66212: Patch
https://bugs.webkit.org/attachment.cgi?id=66212&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66212&action=prettypatch
> WebCore/bindings/v8/V8GCController.cpp:400
> -int getMemoryUsageInMB()
> +int getMemoryUsageInMB(bool noCache)
Instead of using a bool, please use an enum so we can understand what passing
"true" means at the callsites.
More information about the webkit-reviews
mailing list