[webkit-reviews] review granted: [Bug 39582] [Cairo] Enhance the performance of shadowed elements by tiling the shadow area : [Attachment 66179] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 39582: [Cairo] Enhance the performance of shadowed elements by tiling the
shadow area
https://bugs.webkit.org/show_bug.cgi?id=39582

Attachment 66179: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=66179&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66179&action=prettypatch

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:628
> +    // drawTiledShadow still does not work with rotations
Please add a period to the end of this sentence before landing.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1442
> +    // drawTiledShadow still does not work with rotations
Same here.

This looks good to me. Eventually much of this should be separated out into
another class. We should share ContextShadow. I think I'll start on that today.
We need to ensure that shadows for non-rectangular shapes are fast as well.