[webkit-reviews] review denied: [Bug 42815] getBoundingClientRect Broken for SVG Elements : [Attachment 66167] Fix and layout test, take 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 1 05:29:33 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 42815: getBoundingClientRect Broken for SVG Elements
https://bugs.webkit.org/show_bug.cgi?id=42815

Attachment 66167: Fix and layout test, take 2
https://bugs.webkit.org/attachment.cgi?id=66167&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi Cosmin,

the patch itself looks fine, but I want to see more tests, especially in the
context of zooming & scrolling.
Have a look at svg/zoom/page and copy your testcase there, and add the logic
that zooms the page several times.
Also grep for "overflow: scroll" in svg/custom, you can find some tests as
template for you.

Thanks in advance,
Niko


More information about the webkit-reviews mailing list