[webkit-reviews] review requested: [Bug 44896] Add culling to RenderSVGContainer : [Attachment 66186] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 1 03:09:34 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 44896: Add culling to RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=44896

Attachment 66186: Initial patch
https://bugs.webkit.org/attachment.cgi?id=66186&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Eric, you were absolutely right. The patch still had a bug in it, which caused
the pixel test & textual changes.
Note to self: Never land past midnight, after a full conference day. Sorry for
that.

We applied the shadow twice in RenderSVGRoot::updateCachedBoundaries, leading
to bigger boundaries, and larger clipping area, causing a pixel test change
(1px wasn't clipped away anymore in the svg/css/composite-shadow* tests).
No more LayoutTests changes with this patch.


More information about the webkit-reviews mailing list