[webkit-reviews] review denied: [Bug 44957] Web Inspector, Extension API: Panel.onSelectionChanged event is never fired : [Attachment 66073] patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 44957: Web Inspector, Extension API: Panel.onSelectionChanged event is
never fired
https://bugs.webkit.org/show_bug.cgi?id=44957

Attachment 66073: patch
https://bugs.webkit.org/attachment.cgi?id=66073&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66073&action=prettypatch

> WebCore/inspector/front-end/ExtensionServer.js:225
> +	       var result = window.eval(
I believe we can get rid of this eval by providing the function body directly
or even call the eval without wrapping it into an anonymous function as we
discussed offline. A bigger problem is that this code doesn't allow extensions
to declare global functions, r- for this.