[webkit-reviews] review canceled: [Bug 47903] [EFL] Sets default user agent : [Attachment 71528] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 47903: [EFL] Sets default user agent
https://bugs.webkit.org/show_bug.cgi?id=47903

Attachment 71528: Patch
https://bugs.webkit.org/attachment.cgi?id=71528&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I define user agent version macros in cmake/OptionEfl.cmake as
PROJECT_VERSION_XXX.

So, the WEBKIT_USER_AGENT_MAJOR_VERSION / WEBKIT_USER_AGENT_MINOR_VERSION
macro's vaules are also set from cmake/OptionsEfl.cmake, and they are set
during the build time.

  8 #define WEBKIT_USER_AGENT_MAJOR_VERSION @USER_AGENT_VERSION_MAJOR@
  9 #define WEBKIT_USER_AGENT_MINOR_VERSION @USER_AGENT_VERSION_MINOR@


Kenneth,

How do you think about this approach ?