[webkit-reviews] review granted: [Bug 48477] [Chromium] Crash when encountering history.back() call during Page::goToItem execution : [Attachment 72122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 31 18:13:49 PDT 2010


Adam Barth <abarth at webkit.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 48477: [Chromium] Crash when encountering history.back() call during
Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

Attachment 72122: Patch
https://bugs.webkit.org/attachment.cgi?id=72122&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72122&action=review

> LayoutTests/http/tests/history/resources/back-during-onload-container.html:2
> +onload = function() {

Please use window.onload so we can run these tests in other browsers.

> LayoutTests/http/tests/history/resources/back-during-onload-hung-page.php:1
> +<? sleep(1000); ?>

Don't we need to say "<?php"  ?


More information about the webkit-reviews mailing list