[webkit-reviews] review granted: [Bug 44876] QWebElement::toOuterXml() and QWebElement::toInnerXml() return invalid XML : [Attachment 72468] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 31 12:03:37 PDT 2010
Andreas Kling <kling at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 44876: QWebElement::toOuterXml() and QWebElement::toInnerXml() return
invalid XML
https://bugs.webkit.org/show_bug.cgi?id=44876
Attachment 72468: Patch
https://bugs.webkit.org/attachment.cgi?id=72468&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72468&action=review
r=me, just two things:
> WebKit/qt/Api/qwebelement.cpp:319
> + text/xhtml+xml.
text/xhtml+xml should be in apostrophes like below.
> WebKit/qt/ChangeLog:23
> + Reviewed by NOBODY (OOPS!).
Something's up with this ChangeLog entry :)
More information about the webkit-reviews
mailing list