[webkit-reviews] review granted: [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation : [Attachment 72437] Revised after Kenneth's comments

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 47070: [Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Attachment 72437: Revised after Kenneth's comments
https://bugs.webkit.org/attachment.cgi?id=72437&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72437&action=review

> WebCore/platform/graphics/texmap/TextureMapper.h:1
> -/*
> + /*

Is thi change correct>?

> WebKit/qt/Api/qwebframe.cpp:328
> +#if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER)
> +void QWebFramePrivate::renderCompositedLayers(GraphicsContext* context,
const IntRect& clip)
> +{
> +    if (!rootGraphicsLayer)
> +	   return;
> +    if (!textureMapper)
> +	   textureMapper = TextureMapper::create(context);
> +    textureMapper->setGraphicsContext(context);
> +   
textureMapper->setImageInterpolationQuality(context->imageInterpolationQuality(
));
> +    textureMapper->setTextDrawingMode(context->textDrawingMode());
> +    QPainter* painter = context->platformContext();
> +    FrameView* view = frame->view();
> +    painter->save();
> +    painter->beginNativePainting();
> +    TextureMapperContentLayer::PaintOptions options;
> +    options.visibleRect = clip;
> +    options.targetRect = view->frameRect();
> +    options.viewportSize = view->size();
> +    options.opacity = painter->opacity();
> +    rootGraphicsLayer->paint(textureMapper.get(), options);
> +    painter->endNativePainting();
> +    painter->restore();
> +}
> +#endif

Can't you use newlines to group this more logically... That would make reading
it a bit easier... like an empty newline after return