[webkit-reviews] review requested: [Bug 48686] Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept : [Attachment 72430] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 30 00:40:44 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 48686: Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new
SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Attachment 72430: Patch v2
https://bugs.webkit.org/attachment.cgi?id=72430&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Tested a local mac build, now works w/o problems and zero regressions. It fixed
two svg/dynamic-updates tests, that were silently failing before. Also
discovered errors in two of them, regarding SVGLengthList (which did not
properly remove items from a list, if they were already present in another list
- fixed by switching to the new svg animated list property handling).

Patch is larger, as tests have been added that check StrictTypeChecking for all
SVGAnimated* types that have been converted recently. The actual code size is
smaller!


More information about the webkit-reviews mailing list