[webkit-reviews] review granted: [Bug 48444] Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox : [Attachment 72376] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 29 13:12:52 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 48444: Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox,
InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=48444

Attachment 72376: Patch
https://bugs.webkit.org/attachment.cgi?id=72376&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72376&action=review

> WebCore/rendering/RenderBox.h:382
> +    int convertFromFlippedWritingMode(int);

I think a parameter name here would be helpful.

Should this instead have a name like
"convertFromLogicalToPhysicalVerticalPosition" or just
"toPhysicalVerticalPosition"?

> WebCore/rendering/RenderLineBoxList.cpp:173
> +bool RenderLineBoxList::anyLinesIntersectDirtyRect(RenderBoxModelObject*
renderer, const PaintInfo& paintInfo, int tx, int ty, bool usePrintRect) const

I might have moved the "s" from "Lines" to "Intersect":
anyLineIntersectsDirtyRect.

> WebCore/rendering/RenderLineBoxList.h:74
>  private:
> +    bool anyLinesIntersectDirtyRect(RenderBoxModelObject*, const PaintInfo&,
int x, int y, bool usePrintRect) const;
> +    bool lineIntersectsDirtyRect(RenderBoxModelObject*, InlineFlowBox*,
const PaintInfo&, int x, int y) const;
> +    bool rangeIntersectsDirtyRect(RenderBoxModelObject*, int logicalTop, int
logicalBottom, const PaintInfo&, int x, int y) const;
> +
> +private:

What's with the double private:?


More information about the webkit-reviews mailing list