[webkit-reviews] review granted: [Bug 48657] [chromium] add debug logging to help diagnose flakiness dashboard issues : [Attachment 72365] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 29 12:19:54 PDT 2010


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 48657: [chromium] add debug logging to help diagnose flakiness dashboard
issues
https://bugs.webkit.org/show_bug.cgi?id=48657

Attachment 72365: Patch
https://bugs.webkit.org/attachment.cgi?id=72365&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72365&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:966
>	   files = [(file, os.path.join(self._options.results_directory, file))

>	       for file in json_files]

Using a tuple here instead of a struct-like class makes me sad.


More information about the webkit-reviews mailing list