[webkit-reviews] review granted: [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value : [Attachment 72203] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 29 11:18:45 PDT 2010


James Robinson <jamesr at chromium.org> has granted Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 48094: Setting globalAlpha on canvas and drawing a video does not honor
alpha value
https://bugs.webkit.org/show_bug.cgi?id=48094

Attachment 72203: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=72203&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Looks good!  Can you please patch PlatformContextSkia::State::applyAlpha() to
use getNormalizeAlpha() as well so there's only one copy of that logic?


More information about the webkit-reviews mailing list