[webkit-reviews] review granted: [Bug 48626] [Qt] Make GraphicsContext cheaper to construct : [Attachment 72320] Proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 48626: [Qt] Make GraphicsContext cheaper to construct
https://bugs.webkit.org/show_bug.cgi?id=48626

Attachment 72320: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=72320&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72320&action=review

> WebCore/ChangeLog:10
> +	   - Don't call setPlatform*(), set the painter brush and pen directly.


Maybe add a comment about this in the code so that noone adds setPlatform in
the future.

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:238
> +    // use the default the QPainter was constructed with

Comments start with capital letter and ends with a dot, you should know that by
now :-)

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:257
> +    // solidColor is initialized with the fillColor()

Again! </3