[webkit-reviews] review canceled: [Bug 48623] Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept : [Attachment 72312] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 29 05:30:33 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has canceled  review:
Bug 48623: Convert SVGAnimatedEnumeration/Integer to the new
SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48623

Attachment 72312: Patch
https://bugs.webkit.org/attachment.cgi?id=72312&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
It only builds on mac after touching CodeGeneratorObjC.pm, dependency tracking
is obviously broken. If I only modfiy CodeGenerator.pm, the objc bindings are
not regenerated,  only the js bindings :/

I'll need to add whitespace to CodeGeneratorObjC.pm, to fix the build.
Found a local regression though, need to investigate first, clearing Dirks r+
for the meanwhile.


More information about the webkit-reviews mailing list