[webkit-reviews] review requested: [Bug 45443] [GTK] Support for viewport meta tag : [Attachment 72287] Proposed Patch9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 28 19:59:37 PDT 2010


Joone Hur <joone at kldp.org> has asked  for review:
Bug 45443: [GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Attachment 72287: Proposed Patch9
https://bugs.webkit.org/attachment.cgi?id=72287&action=review

------- Additional Comments from Joone Hur <joone at kldp.org>
I applied Martin and Kov's comments to the patch.
Also, I have renamed webViewGetDPI to webkit_web_view_get_dpi and made it a
private function to be called by webkit_viewport_attributes_recompute.
I am wondering if it makes sense.

Any suggestions are appreciated.
Thank you.


More information about the webkit-reviews mailing list