[webkit-reviews] review granted: [Bug 48576] Let WebKit2 client know when a frame is a frameset : [Attachment 72267] updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 48576: Let WebKit2 client know when a frame is a frameset
https://bugs.webkit.org/show_bug.cgi?id=48576

Attachment 72267: updated patch
https://bugs.webkit.org/attachment.cgi?id=72267&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72267&action=review

> WebCore/loader/FrameLoaderClient.h:227
> +	   virtual void dispatchDidBecomeFrameset(bool) = 0; // Can change back
due to navigation or DOM modification.

Not sure the word “back” here is helpful.

> WebKit2/ChangeLog:31
> +2010-10-28  Alexey Proskuryakov  <ap at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).

Double change log.