[webkit-reviews] review denied: [Bug 46663] FrameLoaderClient::didTransferChildFrameToNewDocument needs access to old page : [Attachment 72245] rollback api change

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 46663: FrameLoaderClient::didTransferChildFrameToNewDocument needs access
to old page
https://bugs.webkit.org/show_bug.cgi?id=46663

Attachment 72245: rollback api change
https://bugs.webkit.org/attachment.cgi?id=72245&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72245&action=review

Small ChangeLog nit.
r- since it's going via cq, so needs to be changed first.

> WebCore/ChangeLog:5
> +	   Rollback:

Could you add revisions, as in: Rollback of <url to rev in trac>:

Also, since you edit it manually, lets add a reason for rollback (design
changed, no need for parameter).

> WebKit/chromium/ChangeLog:5
> +	   Rollback:

Ditto here (rev number and reason, also for all ChangeLogs)