[webkit-reviews] review granted: [Bug 47888] chrome.dll!WebCore::Node::shadowAncestorNode ReadAV at NULL (98643190851b5662363449cc7303d8a5) : [Attachment 72242] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 28 15:33:06 PDT 2010


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 47888: chrome.dll!WebCore::Node::shadowAncestorNode ReadAV at NULL
(98643190851b5662363449cc7303d8a5)
https://bugs.webkit.org/show_bug.cgi?id=47888

Attachment 72242: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=72242&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72242&action=review

> LayoutTests/editing/style/fix-range-from-root-editable-crash.html:7
> +    layoutTestController.waitUntilDone();

Does the crash trigger if you don't have the waitUntilDone?  I think DRT makes
sure that onload runs.

> LayoutTests/editing/style/fix-range-from-root-editable-crash.html:18
> +    document.execCommand("SelectAll",	 false, "ur");
> +    document.designMode = "on";
> +    document.execCommand("InsertOrderedList", false, "-.8");
> +    document.execCommand("insertparagraph",	 false, "04");
> +    document.execCommand("InsertImage",	 false, "///(");
> +    document.execCommand("SelectAll",	 false, "ur");
> +    document.execCommand("strikethrough",	 false, null);
> +    document.body.innerHTML = 'This tests
ApplyStyleCommand::fixRangeAndApplyInlineStyle does not crash when startNode is
body.<br>PASS';

Are all these calls necessary?


More information about the webkit-reviews mailing list