[webkit-reviews] review denied: [Bug 48450] [Qt] Extend the Platform Plugin to define the padding of HitTestResult : [Attachment 72219] Adding the TouchAdjusts extension in the Platform Plugin.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 28 13:30:52 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Andre Pedralho
<andre.pedralho at gmail.com>'s request for review:
Bug 48450: [Qt] Extend the Platform Plugin to define the padding of
HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=48450
Attachment 72219: Adding the TouchAdjusts extension in the Platform Plugin.
https://bugs.webkit.org/attachment.cgi?id=72219&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
I like to have this more like the Haptics. Thus call the Extension for Touch,
and just make the plugin implement something like:
class QWebTouchInteraction : public QObject {
enum PaddingDirection { ... }
virtual int hitTestPaddingForTouch(const PaddingDirection) const = 0;
}
I dislike the Adjust* and the setHitTestPadding is unneeded.
More information about the webkit-reviews
mailing list