[webkit-reviews] review denied: [Bug 48440] [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView : [Attachment 72198] Style fixed

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 48440: [Qt] QtTestBrowser: User input lost when toggling use of
QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=48440

Attachment 72198: Style fixed
https://bugs.webkit.org/attachment.cgi?id=72198&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72198&action=review

> WebKitTools/QtTestBrowser/launcherwindow.cpp:97
> +    QUrl url = addressUrl();

In your code below (impl of addressUrl) you return a string, which you convert
into an QUrl here.

> WebKitTools/QtTestBrowser/launcherwindow.cpp:143
> +	   load(url.toString());

Here you convert it into a string again!

> WebKitTools/QtTestBrowser/mainwindow.cpp:120
> +QString MainWindow::addressUrl() const
> +{
> +    return urlEdit->text();
> +}

This is what I mean!