[webkit-reviews] review denied: [Bug 48440] [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView : [Attachment 72182] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Dinu Jacob <dinu.jacob at Nokia.com>'s
request for review:
Bug 48440: [Qt] QtTestBrowser: User input lost when toggling use of
QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=48440

Attachment 72182: Patch
https://bugs.webkit.org/attachment.cgi?id=72182&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72182&action=review

First off, this behavior sounds a bit strange behavior to me, shouldn't we load
what's currently loaded, and simply preserve the text in the location edit?

> WebKitTools/QtTestBrowser/launcherwindow.cpp:97
> +    QUrl url =  getAddressUrl();

Extra space after =

> WebKitTools/QtTestBrowser/mainwindow.h:56
> +    QString getAddressUrl() const;

Name should be "addressUrl"