[webkit-reviews] review denied: [Bug 48227] [GTK] Handle surrogate pairs in TextBreakIteratorGtk : [Attachment 72020] Previous patch with ChangeLog fixed

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 48227: [GTK] Handle surrogate pairs in TextBreakIteratorGtk
https://bugs.webkit.org/show_bug.cgi?id=48227

Attachment 72020: Previous patch with ChangeLog fixed
https://bugs.webkit.org/attachment.cgi?id=72020&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72020&action=review

Very nice! I just have a couple very small comments.

> WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:31
> +using namespace std;

I think I'd prefer the functions you're using to be explicit here.

using std::max; for example.

> WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:33
> +#define IS_SURROGATE(character) (character >= 0x10000 && character <=
0x10FFFF)

I think this should probably be called UTF8_IS_SURROGATE just to be clear that
it deals with UTF-8 characters.

> WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:77
> +    long utf8len = 0;

According to the style guidelines, this should be utf8Length.