[webkit-reviews] review granted: [Bug 48494] fix setSize() order in WebP image decoding : [Attachment 72144] fix setSize() calls in WEBPImageDecoder.cpp

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Pascal Massimino
<pascal.massimino at gmail.com>'s request for review:
Bug 48494: fix setSize() order in WebP image decoding
https://bugs.webkit.org/show_bug.cgi?id=48494

Attachment 72144: fix setSize() calls in WEBPImageDecoder.cpp
https://bugs.webkit.org/attachment.cgi?id=72144&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72144&action=review

> WebCore/ChangeLog:3
> +	   Reviewed by NOBODY (OOPS!).

This line is ok because the tools fill in the reviewer automatically for you.

> WebCore/ChangeLog:6
> +	   fix setSize() call flow: it was only called the first
> +	   time (when onlySize is true)

Also, you should link to the bug from the ChangeLog so folks can find it from
the SVN revision history.

> WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

There's an SVN pre-commit hook that rejects OOPS in files.  This line will
prevent the patch from being landed.  You should replace this line with an
explanation of why there is no test.