[webkit-reviews] review requested: [Bug 48078] Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word. : [Attachment 72135] Proposed patch (v2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 21:10:19 PDT 2010


jpu at apple.com has asked  for review:
Bug 48078: Editing a word with misspell or autocorrection underline should
remove the underline when the editing changes the word.
https://bugs.webkit.org/show_bug.cgi?id=48078

Attachment 72135: Proposed patch (v2)
https://bugs.webkit.org/attachment.cgi?id=72135&action=review

------- Additional Comments from jpu at apple.com
In addition to changes based on comment #3, there're following major
differences compared with previous patch:
1. Refactored DocumentMarkerController::removeMarkers() and added
DocumentMarkerController::hasMarker() to make marker manipulation more
convenient.
2. Moved some calls to
Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() from Editor to
TypingCommand, so that it gets called by both testing script and actual typing.

3. Added tests.


More information about the webkit-reviews mailing list