[webkit-reviews] review granted: [Bug 48489] Work around a Mac driver bug in generateMipmap : [Attachment 72124] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 48489: Work around a Mac driver bug in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=48489

Attachment 72124: patch
https://bugs.webkit.org/attachment.cgi?id=72124&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72124&action=review

Excellent work tracking this down. There is one error in the ChangeLog though.
Please fix before committing.

> WebCore/ChangeLog:9
> +	   (WebCore::WebGLRenderingContext::generateMipmap): Make sure
minFilter is set to LINEAR_MIPMAP_LINEAR before generateMipmap, and after the
call, set it back to the original value.

This should be NEAREST_MIPMAP_LINEAR.