[webkit-reviews] review granted: [Bug 48488] [chromium] add a master-name flag to new-run-webkit-tests : [Attachment 72120] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 48488: [chromium] add a master-name flag to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=48488

Attachment 72120: Patch
https://bugs.webkit.org/attachment.cgi?id=72120&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72120&action=review

>> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958
>> +
> 
> Is there a reason you didn't just add
> 
> if not self._options.test_results_server:
>     raise AssertionError()
> 
> or something here instead of adding a FIXME?

I assume we need to add the flags to the bots, which is a server change?  I
guess we could do that first.  Once we require it, we can unit tests this
requirement.

Seems fine for now.