[webkit-reviews] review granted: [Bug 48484] Improve memSize calculation in [WebView _setCacheModel] : [Attachment 72118] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Pratik Solanki <psolanki at apple.com>'s
request for review:
Bug 48484: Improve memSize calculation in [WebView _setCacheModel]
https://bugs.webkit.org/show_bug.cgi?id=48484

Attachment 72118: Patch
https://bugs.webkit.org/attachment.cgi?id=72118&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72118&action=review

Changes look fine. I have a comment or two, but nothing we couldn’t tweak
later.

> WebKit/mac/WebView/WebView.mm:5324
> +    static uint64_t memSize = roundUpToPowerOf2(WebMemorySize() / 1024 /
1024);

Is it really worthwhile to store this in a global? Paying 8 bytes of global
memory to avoid doing this math more than once might be the wrong tradeoff
since we do this computation only when the cache model is changed.