[webkit-reviews] review granted: [Bug 48479] queryCommandValue should fall back to queryCommandState : [Attachment 72113] fixes the bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 48479: queryCommandValue should fall back to queryCommandState
https://bugs.webkit.org/show_bug.cgi?id=48479

Attachment 72113: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=72113&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72113&action=review

I’m surprised that this functions works that way, but change looks OK. Do any
of the test cases cover the mapping of mixed state to "false"?

> LayoutTests/editing/execCommand/script-tests/query-text-alignment.js:7
> +function isEquivalentBoolean(string, bool) {

The function name here isn't all that clear.