[webkit-reviews] review denied: [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value : [Attachment 72108] Proposed Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 48094: Setting globalAlpha on canvas and drawing a video does not honor
alpha value
https://bugs.webkit.org/show_bug.cgi?id=48094

Attachment 72108: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=72108&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Based on the checksums the windows and linux expectations are dups of each
other - please remove the chromium-linux version (it'll fall back to
chromium-win if there is nothing in chromium-linux).

If we already have this rounding logic twice, it really should be shared
somewhere.  Could you put this somewhere shared (maybe another getter on
PlatformContextSkia - getNormalizedAlpha() - and change ImageSkia.cpp to use
that as well)?

R- for the dupe expectations.