[webkit-reviews] review granted: [Bug 48236] Add support for loading each test several times in chromium Python test runner : [Attachment 71848] Addressed comments #5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 16:45:27 PDT 2010


Eric Seidel <eric at webkit.org> has granted Søren Gjesse <sgjesse at chromium.org>'s
request for review:
Bug 48236: Add support for loading each test several times in chromium Python
test runner
https://bugs.webkit.org/show_bug.cgi?id=48236

Attachment 71848: Addressed comments #5
https://bugs.webkit.org/attachment.cgi?id=71848&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71848&action=review

I'm willing to rs=me this.  As Pavel said, your ChangeLog should point to the
bug.  If you're using webkit-patch upload it will create a properly formated
changelog for you.

You'll need to post a new patch if you want to use the commit-queue.

> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:394
> +
> +

Why the extra newline?


More information about the webkit-reviews mailing list