[webkit-reviews] review denied: [Bug 48002] network-simulator.php makes for very slow layout tests : [Attachment 72099] faster network simulator

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 48002: network-simulator.php makes for very slow layout tests
https://bugs.webkit.org/show_bug.cgi?id=48002

Attachment 72099: faster network simulator
https://bugs.webkit.org/attachment.cgi?id=72099&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72099&action=review

Nice, but please don't change existing tests.

> LayoutTests/http/tests/resources/network-simulator.php:5
> +// offline, it simulates a network error with a non-sense response.

What's the difference between non-sense and nonsense? Most dictionaries don't
seem to include this spelling.

> LayoutTests/http/tests/resources/network-simulator.php:66
> +	   header('Content-Length: 1');
> +	   header('Content-Length: 5', false); # multiple content-length
headers

A good comment would explain why we have these lines (like, it helps some
network back-ends detect the error faster).