[webkit-reviews] review denied: [Bug 48467] Add VectorMath files : [Attachment 72088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 14:52:13 PDT 2010


Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 48467: Add VectorMath files
https://bugs.webkit.org/show_bug.cgi?id=48467

Attachment 72088: Patch
https://bugs.webkit.org/attachment.cgi?id=72088&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
These routines should be placed either in a namespace (WebCore / VectorMath) or
as static methods on a class. The implementation can then re-direct to
Accelerate.framework. Polluting the global namespace on all platforms is very
sub-optimal.


More information about the webkit-reviews mailing list