[webkit-reviews] review requested: [Bug 46579] Reproducible crash in appcache code when closing pgatour.com : [Attachment 72089] patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 46579: Reproducible crash in appcache code when closing pgatour.com
https://bugs.webkit.org/show_bug.cgi?id=46579

Attachment 72089: patch
https://bugs.webkit.org/attachment.cgi?id=72089&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This was also reported to chromium in http://crbug.com/52772.

The attached patch continues to use m_pageDismissalEventBeingDispatched in the
same way internally to FrameLoader, but changes the way it is exposed to check
whether any frame in the tree is dispatching a page dismissal event. This
ensures that we use PingLoader for all loads from unload handlers, even if the
load is being handled in a different frame.

Note that as a part of this patch, I've also extended PingLoader to be
triggered for all CachedResource loads, not just images. If this isn't desired,
it can easily be removed.