[webkit-reviews] review granted: [Bug 48385] Add WebKit SPI to scale a WebView : [Attachment 72083] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 48385: Add WebKit SPI to scale a WebView
https://bugs.webkit.org/show_bug.cgi?id=48385

Attachment 72083: Patch
https://bugs.webkit.org/attachment.cgi?id=72083&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72083&action=review

I noticed that the Qt EWS had a failure; you should check into that.

> WebCore/page/Frame.cpp:977
> +    Document* document = this->document();
> +    if (!document)
> +	   return;
> +
> +    m_pageScaleFactor = scale;

We should probably set m_pageScaleFactor even before checking the document for
0.

> WebCore/page/Frame.cpp:987
> +    document->recalcStyle(Node::Force);
> +
> +    if (FrameView* view = this->view()) {
> +	   if (document->renderer() && document->renderer()->needsLayout() &&
view->didFirstLayout())
> +	       view->layout();
> +    }

Why do we need to do all this synchronously? Can’t we use the normal machinery
to do the style and layout instead of forcing it immediately? This is probably
OK for now, but I think we can tighten it up later.