[webkit-reviews] review granted: [Bug 47027] refactor the nested large switch statements in GraphicsContext3DCG.cpp:getImageData() : [Attachment 72058] revised patch: responding to kbr's review

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 47027: refactor the nested large switch statements in
GraphicsContext3DCG.cpp:getImageData()
https://bugs.webkit.org/show_bug.cgi?id=47027

Attachment 72058: revised patch: responding to kbr's review
https://bugs.webkit.org/attachment.cgi?id=72058&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72058&action=review

Looks good. One comment.

> WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:62
> +static GraphicsContext3D::SourceDataFormat getSourceDataFormat(unsigned int
componentsPerPixel, AlphaFormat alphaFormat, bool is16BitFormat, bool
bigEndian)

Please add a comment indicating that this returns kSourceFormatNumFormats if
the combination of input parameters is unsupported.