[webkit-reviews] review denied: [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value : [Attachment 71930] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 11:19:25 PDT 2010


James Robinson <jamesr at chromium.org> has denied Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 48094: Setting globalAlpha on canvas and drawing a video does not honor
alpha value
https://bugs.webkit.org/show_bug.cgi?id=48094

Attachment 71930: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=71930&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
This looks like a pixel test, so it needs expectations
(video-canvas-alpha-expected.txt, .checksum, and .png).

Are you sure about that rounding/clipping logic?  Is it needed?  Do we do this
anywhere else?


More information about the webkit-reviews mailing list