[webkit-reviews] review granted: [Bug 48439] Web Inspector: Need WebKit2 API for enabling developer extras : [Attachment 72055] Proposed Change
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 27 11:09:27 PDT 2010
John Sullivan <sullivan at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 48439: Web Inspector: Need WebKit2 API for enabling developer extras
https://bugs.webkit.org/show_bug.cgi?id=48439
Attachment 72055: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=72055&action=review
------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72055&action=review
> WebKit2/Shared/WebPreferencesStore.cpp:48
> + , developerExtrasEnabled(false)
Maybe we should keep these sorted (I think they started that way, but
privateBrowsingEnabled is out of order).
> WebKit2/Shared/WebPreferencesStore.cpp:83
> + encoder->encode(developerExtrasEnabled);
Same here.
> WebKit2/Shared/WebPreferencesStore.cpp:121
> + return false;
Same here.
More information about the webkit-reviews
mailing list