[webkit-reviews] review granted: [Bug 48436] REGRESSION (r70335): Incorrect article layout in Safari Reader : [Attachment 72054] Disable the cross-origin check in getMatchedCSSRules in versions of Safari lined against versions of WebKit that didn’t have the check

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 48436: REGRESSION (r70335): Incorrect article layout in Safari Reader
https://bugs.webkit.org/show_bug.cgi?id=48436

Attachment 72054: Disable the cross-origin check in getMatchedCSSRules in
versions of Safari lined against versions of WebKit that didn’t have the check
https://bugs.webkit.org/attachment.cgi?id=72054&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72054&action=review

> WebCore/ChangeLog:9
> +	   (WebCore::DOMWindow::getMatchedCSSRules): Return rules from all
origins if the corss-origin

Typo: corss

> WebCore/page/DOMWindow.cpp:1257
>      Document* doc = m_frame->document();

This local variable doesn’t seem to keep its weight.

> WebCore/page/Settings.h:336
> +	   bool disableGetMatchedCSSRulesCrossOriginCheck() const { return
m_disableGetMatchedCSSRulesCrossOriginCheck; }

For functions that return booleans, I prefer that we not use verb phrases such
as “disable”.

> WebCore/page/Settings.h:425
> +	   bool m_disableGetMatchedCSSRulesCrossOriginCheck : 1;

Same thing for data members.