[webkit-reviews] review requested: [Bug 5793] HTML OBJECT without width/height attributes doesn't honor the size of the image : [Attachment 72053] Proposed patch with accepting reviewer's comment.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 10:22:22 PDT 2010


Julie Jeongeun Kim <jiyuluna at gmail.com> has asked  for review:
Bug 5793: HTML OBJECT without width/height attributes doesn't  honor the size
of the image
https://bugs.webkit.org/show_bug.cgi?id=5793

Attachment 72053: Proposed patch with accepting reviewer's comment.
https://bugs.webkit.org/attachment.cgi?id=72053&action=review

------- Additional Comments from Julie Jeongeun Kim <jiyuluna at gmail.com>
I changed code additionally.
1.Removed code for debugging.
2.Kept 'IntSize windowSize = IntSize(view->width(), view->height());' but I
added null check, as other APIs in ImageDocument did.
3.condition and declaration were combined.

As to new test case,
I think the test case attached here is suitable.
Please let me know how to apply it.

* I've done other tests with 'run-webkit-tests'. 

Thanks,


More information about the webkit-reviews mailing list